Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all configuration #250

Merged
merged 8 commits into from
Jun 15, 2021
Merged

Conversation

darkred
Copy link
Contributor

@darkred darkred commented Jun 14, 2021

Implements #247

I hope I didn't miss anything.

Note to reviewers:

I see that the last test action CI / update fails but I can't find why.

@ota-meshi
Copy link
Owner

I see that the last test action CI / update fails but I can't find why.

Run the npm run update command.

@darkred
Copy link
Contributor Author

darkred commented Jun 14, 2021

I just did (while on my add-all-configuration branch)
and the resulting uncommitted changes reverted my changes in README.md and all.ts *(it's now identical to recommended.ts).
Please see screenshots of the changes: 1, 2, 3

docs/user-guide/README.md Outdated Show resolved Hide resolved
docs/user-guide/README.md Outdated Show resolved Hide resolved
docs/user-guide/README.md Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Collaborator

I think the easiest way to make the all config is to import the recommended config, make a copy of it and then add all rules that aren't included already. This would also mean that won't have to change any scripts/* files and won't have problems with npm run update.

@RunDevelopment RunDevelopment added the enhancement New feature or request label Jun 14, 2021
@ota-meshi
Copy link
Owner

docs/user-guide/README.md is automatically generated from README.md. Update README.md and run npm run update.

darkred and others added 4 commits June 14, 2021 16:08
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@darkred
Copy link
Contributor Author

darkred commented Jun 14, 2021

@ota-meshi
To be sure, I deleted my cloned directory altogether, then cloned again my fork.

Then I just updated README.md (I mean the root one)
and ran npm run update
and now my lib\configs\all.ts once again became identical to lib\configs\recommended.ts (uncommitted changes).

How can I fix this? What have I missed?

@RunDevelopment
Copy link
Collaborator

now my lib\configs\all.ts once again became identical to lib\configs\recommended.ts (uncommitted changes).

How can I fix this? What have I missed?

Well, in tools/update-rulesets.ts you instruct npm run update to do exactly that. Just revert the file.

lib/configs/all.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your contribution!

@ota-meshi ota-meshi merged commit 0144e3e into ota-meshi:master Jun 15, 2021
@darkred darkred deleted the add-all-configuration branch June 15, 2021 08:55
@darkred
Copy link
Contributor Author

darkred commented Jun 15, 2021

You are welcome. I'm glad I could contribute!
Thank you both for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants