Fix mergeOverlappingSets implementation
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
force-pushed
the
mergeOverlappingSets-fix
branch
from
2e5a702
to
ee5a8ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
mergeOverlappingSets. The function returned more elements than it was supposed to.I took this chance and reimplemented the function using a simpler and a lot more efficient approach.
Further, I changed the function's interface to take and return arrays instead of sets. This make a lot of copying and array-to-set conversions unnecessary.
This is a branch of #320 because the new test case only reproduces the bug I fixed with the new and improved
getLongestPrefix.