Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix control-character-escape false negatives #327

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Fix control-character-escape false negatives #327

merged 1 commit into from
Sep 13, 2021

Conversation

RunDevelopment
Copy link
Collaborator

fixes #326.

I used PatternSource's replace ranges to determine whether the control character is part of a RegExp literal or not.

image

@RunDevelopment RunDevelopment added the bug Something isn't working label Sep 13, 2021
ota-meshi
ota-meshi approved these changes Sep 13, 2021
View reviewed changes
Copy link
Owner

@ota-meshi ota-meshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@ota-meshi ota-meshi merged commit 6e07030 into master Sep 13, 2021
@ota-meshi ota-meshi deleted the issue326 branch September 13, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

control-character-escape doesn't report control characters in /re/.source expressions
2 participants
@RunDevelopment @ota-meshi