-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for ESLint < v8.44 #558
Conversation
🦋 Changeset detectedLatest commit: effd266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Why exactly would we need to check the ESLint version and branch? The ESLint parser AST represents regexes as |
The old parser will throw a parsing error with the v flag as an unknown flag. Parsing the v flag requires espree v9.6.0 and is definitely included in eslint v8.44.0 and later. https://github.com/eslint/espree/releases/tag/v9.6.0 That said, we can certainly use |
Oh, so we can't even properly test our v-flag rules right now? That certainly is an issue, and I don't like the idea of having to use |
I noticed that ESLint's standard parser can't parse the v flag until ESLint is updated to v8.44.
This PR drops support for ESLint < v8.44.
https://eslint.org/blog/2023/06/eslint-v8.44.0-released/
We could leave the old ESLint support and check the ESLint version, and branch whether or not to test for the v flag, but I think it would be expensive to do that. So I think it makes more sense to drop the old ESLint support.