-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option in block-sequence-hyphen-indicator-newline
#259
feat: Add option in block-sequence-hyphen-indicator-newline
#259
Conversation
🦋 Changeset detectedLatest commit: 12784ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
block-sequence-hyphen-indicator-newline
にオプションを追加するblock-sequence-hyphen-indicator-newline
Thank you for this PR. Could you please add to the rule documentation how the new options work? |
"options": [ | ||
"never", | ||
{ | ||
"nestedHyphen": "always", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases that does not use nestedHyphen.
Thank you for waiting long time. Maybe resolve #243 |
98e28ee
to
e1e11e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I checked the test cases, it seems that they do not include the block mapping test case.
Could you please add xx-input.yml
under tests/fixtures/rules/block-sequence-hyphen-indicator-newline/invalid
and tests/fixtures/rules/block-sequence-hyphen-indicator-newline/valid
directory and write the config using comments at the beginning of files?
Please also refer to https://github.com/ota-meshi/eslint-plugin-yml/blob/master/tests/fixtures/rules/block-mapping/invalid/block-and-comment01-input.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This is my first pull request to this repository, so please let me know if I am doing something wrong.
Also, sorry if I used broken English.
why
JetBrains IDE can fix Yaml file as follows.
Similar to rule
block-sequence-hyphen-indicator-newline
, butblock-sequence-hyphen-indicator-newline
actually adds a line break after all hyphen.what
Add a new option
blockMapping
inblock-sequence-hyphen-indicator-newline
.Defaults, this option is follows global style. If the option is set, it controls the line breaks in the block mapping accordingly.