Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal video player doesn't work on Wayland #60

Closed
JiangHongTiao opened this issue Jul 29, 2017 · 6 comments
Closed

Internal video player doesn't work on Wayland #60

JiangHongTiao opened this issue Jul 29, 2017 · 6 comments

Comments

@JiangHongTiao
Copy link

JiangHongTiao commented Jul 29, 2017

Hi guys,
I have downloaded subtitles&video from: https://www.youtube.com/watch?v=CeBHA2m8xm4
I have dragged and dropped automatically generated subtitles (srt) into the program. Then I have tried to load video, unfortunately app has crashed. Video is of the format.
I'm attaching bugreport and mediainfo information. Thank you for your work and time guys!

**Traceback**

File: /usr/lib/python3.6/site-packages/gaupol/agents/video.py
Line: 184
In: _on_load_video_activate

    self.player.set_path(path)

File: /usr/lib/python3.6/site-packages/gaupol/player.py
Line: 331
In: set_path

    self.set_uri(aeidon.util.path_to_uri(path))

File: /usr/lib/python3.6/site-packages/gaupol/player.py
Line: 340
In: set_uri

    self._xid = self.widget.get_window().get_xid()

AttributeError: 'GdkWaylandWindow' object has no attribute 'get_xid'

**Environment**

Platform: Linux-4.11.10-300.fc26.x86_64-x86_64-with-fedora-26-Twenty_Six
Locale: en_GB.utf_8

**Versions**

aeidon: 1.0
chardet: 2.3.0
enchant: 1.6.10
gaupol: 1.0
gstreamer: 1.12.2.0
gtk+: 3.22.17
pygobject: 3.24.1
python: 3.6.2
@otsaloma otsaloma changed the title Error loading associated video Internal video player doesn't work on Wayland Aug 3, 2017
@otsaloma otsaloma added the bug label Aug 3, 2017
@otsaloma
Copy link
Owner

otsaloma commented Aug 3, 2017

It seems you're running Wayland. I haven't yet tried Gaupol on Wayland myself, but it seems some changes are needed. I'll look into it when I have the time.

As a workaround, does launching Gaupol from a terminal with command GDK_BACKEND=x11 gaupol work?

@JiangHongTiao
Copy link
Author

JiangHongTiao commented Aug 3, 2017 via email

@JiangHongTiao
Copy link
Author

JiangHongTiao commented Aug 3, 2017 via email

otsaloma added a commit that referenced this issue Nov 11, 2017
Hopefully this makes the video player work on Wayland too (#60) without
needing weird special casing in the code using waylandsink. As a
downside gtksink is likely to use a lot more CPU than autovideosink.

This might allow the video player to work on Windows too as we no longer
need a window handle, but with pygi-aio-3.24 it seemed to result in a
crash with "No accelerated IMDCT transform found."

Requiring gtksink bumps the GStreamer dependency to 1.6.
@otsaloma
Copy link
Owner

Could some good folks here running Wayland test the latest development version with the above potential fix? Just download, unpack and run bin/gaupol.

@JiangHongTiao
Copy link
Author

JiangHongTiao commented Nov 11, 2017 via email

@otsaloma
Copy link
Owner

Thanks, I think this is fixed now.

Repository owner deleted a comment from aboofgggg Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants