Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong release version in AppStream XML #219

Merged

Conversation

musicinmybrain
Copy link
Contributor

This fixes validation errors:

$ appstream-util validate-relax --nonet /[...]/io.otsaloma.gaupol.appdata.xml
/[...]/io.otsaloma.gaupol.appdata.xml: FAILED:
• tag-invalid           : <release> version was duplicated
Validation of files failed

(Validation with appstreamcli validate 1.0.2 doesn’t complain about this.)

@otsaloma
Copy link
Owner

otsaloma commented Apr 1, 2024

Oops. Merging. Do I also need to release 1.14.1 so that the latest version would have a valid file? (I don't know how these AppData files propagate...)

@otsaloma otsaloma merged commit 073c5e1 into otsaloma:master Apr 1, 2024
@musicinmybrain
Copy link
Contributor Author

Oops. Merging. Do I also need to release 1.14.1 so that the latest version would have a valid file? (I don't know how these AppData files propagate...)

For me as maintainer of the Fedora package, it doesn’t matter much: I already patched in this PR.

I caught this because Fedora packaging guidelines require validation at build time. I don’t know if there are any systems or distros where an appstream-util validation failure might not be seen by a human, but might prevent Gaupol from appearing in an “app store” or “software center.” From that perspective, there might be value in a patch release.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Apr 9, 2024
https://build.opensuse.org/request/show/1164231
by user 1Antoine1 + anag+factory
- Update to 1.14.1:
  * Fix invalid entry in AppData file (gh#otsaloma/gaupol#219).
- Changes from 1.14:
  * Change the icon for the toggle video player toolbar item to an
    action icon (not mimetype) that has a symbolic version
    available.
  * Fix installation on Python >= 3.12 by using distutils from
    setuptools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants