Update vendor list #257
Merged
Update vendor list #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated vendors from a vid file that was kindly provided to me from ODVA. I wrote a small python script to read the ODVA file and output in a predefined format, so i can update vendors in different tools. To preserve obsolete vendors, i issue a list of them separately.
|
Thank you for this, this is much easier than the scraper I just wrote to pull them from the ODVA marketplace 😂. I think utf-8 is fine, since the id's are what are used in the protocol not the strings. The Reserved ones can be deleted, this list came from the original pycomm library. I plan on working on my v2 stuff a bit this weekend, so I'll work on getting this merged too. |
|
Sorry, I was dealing with a sick puppy all weekend and completely forgot about this... and I'm also out of town until next week. I'll complete this when I get back. |
|
Thanks for commenting, but that's no problem. Hopefully the puppy is up well again. Time doesn't matter that much on my side. |
|
Thanks for merging. Happy to contribute 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated vendors from a vid file that was kindly provided to me from ODVA.
I wrote a small python script to read the ODVA file and output in a predefined format, so i can update vendors in different tools.
To preserve obsolete vendors, i issue a list of them separately.
Some company names have special UTF-8 characters like ü, ä, ç, ã and ）/ U+FF09 and I'm not sure if pycomm3 can handle them at this place in code.
Can someone please acknowledge that this is ok?
There were some Reserved entries in the list. As i do not see any additional value to values that aren't in the list at all, i removed them.
What do you think about that change and should i add the
Reservedentries?