Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-4728 Fix Error 500 on subscriptions page for invalid items #4816

Merged
merged 16 commits into from
Sep 8, 2024
Merged

AO3-4728 Fix Error 500 on subscriptions page for invalid items #4816

merged 16 commits into from
Sep 8, 2024

Conversation

weeklies
Copy link
Contributor

Issue

https://otwarchive.atlassian.net/browse/AO3-4728

Purpose

Updates old #4150 and apply i18n on subscription index page.

Testing Instructions

See Jira.

@weeklies weeklies changed the title AO3-4728 Fix 500 error on subscriptions page for invalid items AO3-4728 Fix Error 500 on subscriptions page for invalid items May 28, 2024
@weeklies weeklies marked this pull request as ready for review May 28, 2024 13:08
sarken
sarken requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'm sorry you inherited the issue I just noticed. 😬

app/views/subscriptions/index.html.erb Outdated Show resolved Hide resolved
sarken
sarken reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you, that's much better! Just one more comment that might make things a bit easier to follow and then I think we're set.

app/controllers/subscriptions_controller.rb Outdated Show resolved Hide resolved
sarken
sarken approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brianjaustin brianjaustin merged commit d4a8dfa into otwcode:master Sep 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarken sarken sarken approved these changes

Assignees
No one assigned
Labels
Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weeklies @sarken @brianjaustin @tlee911