Automatically update version of contracts based on package.json version from changesets #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oveddan
commented
Sep 19, 2023
•
oveddan
commented
- Added a script that updates the contract version from the current package.json version, so we no longer need to manually set it.
- Updated the github changeset action to both update the package.json and contract version
- Added back the test that verifies the contract version matches the package version.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
iainnash
reviewed
Sep 21, 2023
| @@ -24,7 +25,8 @@ | |||
| "storage-inspect:generate": "./script/storage-check.sh generate ZoraCreator1155Impl ZoraCreator1155FactoryImpl", | |||
| "release": "yarn run prepack && changeset publish", | |||
| "js-test:watch": "vitest dev", | |||
| "anvil": "anvil --fork-url https://rpc.zora.energy --fork-block-number 2550000 --chain-id 31337" | |||
| "anvil": "anvil --fork-url https://rpc.zora.energy --fork-block-number 2550000 --chain-id 31337", | |||
| "update-version": "changeset version && yarn update-contract-version" | |||
There was a problem hiding this comment.
Looked and didn't see a simpler way to integrate the call into pre-release
There was a problem hiding this comment.
you could do it in the prepack step, but i thought it should happen only whenever the version is updated.
oveddan
changed the base branch from
changesets-remove-duplicate-ci-task
to
main
oveddan
force-pushed
the
add-back-version-check
branch
from
3506af3 to
10e0af1
Compare
…oth the package.json version and contract version
oveddan
force-pushed
the
add-back-version-check
branch
from
10e0af1 to
f4d5c9f
Compare
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…on from changesets (#192) * adding back ensuring that the package version matches whats in the contract * added script that generates version file * Updated github action to call an update version script that updates both the package.json version and contract version * fix typo * fix version change
iainnash
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.