Add TokenId to redeemInstructionsHashIsAllowed for Redeem Contracts #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveddan
requested changes
Sep 21, 2023
| // address payable internal tokenAdmin = payable(address(0x999)); | ||
| // address payable internal factoryAdmin = payable(address(0x888)); | ||
| // address internal zora; | ||
| contract ZoraCreatorRedeemMinterFactoryTest is Test { |
There was a problem hiding this comment.
thanks for bringing back these tests!
|
looks good! |
oveddan
approved these changes
Sep 22, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Add TokenId to redeemInstructionsHashIsAllowed for Redeem Contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
tokenIdtoredeemInstructionsHashIsAllowedin order to set redeem permissions to be token specific rather than across the collection