Premint - deploy to zora and zora goerli. Deploy determinstic factories and impls to those chains #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
oveddan
force-pushed
the
premint-deploy
branch
from
15f7a82 to
b55030e
Compare
oveddan
force-pushed
the
premint-deploy
branch
from
2d423f5 to
85df045
Compare
|
fork test has a wierd issue thatll be fixed in another PR. main test is bonked cause of version package error |
oveddan
changed the title
iainnash
added a commit
that referenced
this pull request
Jan 11, 2024
…es and impls to those chains (#237) * update protocol rewards package (#226) * updated params * scripts are working for deplyment. have signatures generated * made deploy all script * deploying all to new chain and deploying contract for verification * fix build * added step to test deploying * more test around address being correct * determinstic deploy scripts are working, lets deploy it * bump to v2 * version 2 in contracts * zora goerli deployed * deployed v2 to zora testnet and mainnet * split up proxies * contracts deployed to zora mainnet and testnet * revert changes to other addresses. bump versions deployed to zora and zora goerli * Fix tests to use proxy addresses * udpated changeset --------- Co-authored-by: Iain Nash <iain@zora.co>
iainnash
pushed a commit
that referenced
this pull request
Mar 11, 2024
… having an account as an argument (#237) <!--- Provide a general summary of your changes in the Title above --> ## Description The protocol-sdk readme doesnt take into consideration the fact that the account could be an `Account` and not just an `Address` - so this updates the readme to reflect this ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## Does this change the ABI/API? - [ ] This changes the ABI/API <!-- If so, please describe how and what potential impact this may have --> ## What tests did you add/modify to account for these changes <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New module / feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] i added a changeset to account for this change ## Reviewer Checklist: - [ ] My review includes a symposis of the changes and potential issues - [ ] The code style is enforced - [ ] There are no risky / concerning changes / additions to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.