Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy premint v2 to zora goerli and zora sepolia. Simulate and give instruactions for premint upgrades #378

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 21, 2023

  • updated deployment scripts to not fail if deploying preminter, and its determinstic address is already taken; this means the preminter has already been created, and it now continues gracefully.
  • deployed 2.5.1 to zora sepolia and zora goerli, and upgraded preminter proxy
  • updated upgrade simulation tests to simulate and pending premint upgrades and print necessary calldata

we now can get this output in tests:

Screenshot 2023-11-20 at 7 09 35 PM

This was referenced Nov 21, 2023
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 21, 2023

@oveddan oveddan mentioned this pull request Nov 21, 2023
@oveddan oveddan force-pushed the bump-premint-version branch from 76d2337 to e4b8819 Compare November 21, 2023 02:21
@oveddan oveddan force-pushed the bump-premint-version branch from e4b8819 to e95ac50 Compare November 21, 2023 02:33
@oveddan oveddan changed the title Deploy premint v2 to zora goerli and zora sepolia. Simulate upgrades to them Deploy premint v2 to zora goerli and zora sepolia. Simulate and give instruactions for premint upgrades Nov 21, 2023
kulkarohan
kulkarohan previously approved these changes Nov 21, 2023
@kulkarohan
Copy link
Contributor

lgtm!

thoughts on moving all deploy-related files (eg. ZoraDeployerBase, ZoraDeployerUtils) to /script?

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 21, 2023

lgtm!

thoughts on moving all deploy-related files (eg. ZoraDeployerBase, ZoraDeployerUtils) to /script?

i can see the need for that, but i feel they are more like classes than scrips, and everything in /script is meant for running the script file that is there (they're all .s.sol in there) so if those files are to be moved into there, they should be in a subfolder

@oveddan oveddan changed the base branch from bump-premint-version to main November 21, 2023 16:59
@oveddan oveddan dismissed kulkarohan’s stale review November 21, 2023 16:59

The base branch was changed.

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 21, 2023

already approved, just approval got lost in rebase. merging.

@oveddan oveddan merged commit 128b05c into main Nov 21, 2023
10 checks passed
@oveddan oveddan deleted the deploy-premint-v2 branch November 21, 2023 17:46
iainnash pushed a commit that referenced this pull request Jan 5, 2024
…instruactions for premint upgrades (#378)

* updated deployment scripts to not fail if determinstic address not already created

* improvements on deploy

* deployed 2.5.1 to zora sepolia

* clean up test

* added a test contract deployer

* deploy to zora goerli

* making sure to stop prank

* fix upgrade test

* updated changeset

* remove upgrade needed log
iainnash pushed a commit that referenced this pull request Jan 11, 2024
…instruactions for premint upgrades (#378)

* updated deployment scripts to not fail if determinstic address not already created

* improvements on deploy

* deployed 2.5.1 to zora sepolia

* clean up test

* added a test contract deployer

* deploy to zora goerli

* making sure to stop prank

* fix upgrade test

* updated changeset

* remove upgrade needed log
iainnash pushed a commit that referenced this pull request Jan 11, 2024
…instruactions for premint upgrades (#378)

* updated deployment scripts to not fail if determinstic address not already created

* improvements on deploy

* deployed 2.5.1 to zora sepolia

* clean up test

* added a test contract deployer

* deploy to zora goerli

* making sure to stop prank

* fix upgrade test

* updated changeset

* remove upgrade needed log
oveddan added a commit that referenced this pull request Jul 15, 2024
* draft: Zora Account Manager

* cleanup pr

---------

Co-authored-by: Dan Oved <stangogh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants