Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Syntax Errors in withdrawWithSig Function #459

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

paulfisherz
Copy link
Contributor

@paulfisherz paulfisherz commented Oct 24, 2024

Description

Closes #458

Fixed syntax errors in the withdrawWithSig function within YourContract.sol. Specifically, added a missing comma after the address to parameter and correctly positioned the r parameter in the bytes32 r declaration. These changes ensure that the function compiles successfully without parser errors.

Motivation and Context

These changes are required to resolve syntax errors that were preventing the smart contract from compiling. The missing comma and misplaced r parameter were causing ParserError messages, blocking deployment and halting development workflows. Fixing these issues allows the contract to compile, enabling further development and deployment processes.

Does this change the ABI/API?

  • This changes the ABI/API

What tests did you add/modify to account for these changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New module / feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a changeset to account for this change

Reviewer Checklist:

  • My review includes a symposis of the changes and potential issues
  • The code style is enforced
  • There are no risky / concerning changes / additions to the PR

@paulfisherz paulfisherz changed the title Fix Syntax Errors in withdrawWithSig Function Fix Syntax Errors in withdrawWithSig Function Oct 24, 2024
@iainnash
Copy link
Collaborator

Thanks for catching this in our docs.

@iainnash iainnash requested review from oveddan and iainnash December 2, 2024 15:57
@iainnash iainnash merged commit 037958b into ourzora:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Errors in withdrawWithSig Function: Missing Comma and Misplaced r Parameter
2 participants