Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sslv3.dshield.com and tlsfun.de tests #300

Merged
merged 3 commits into from
Oct 21, 2016
Merged

Remove sslv3.dshield.com and tlsfun.de tests #300

merged 3 commits into from
Oct 21, 2016

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Oct 21, 2016 •
edited
Loading

This pull request removes the following tests:

  • sslv3.dshield.org appears to be offline (see sslv3.dshield.org gone? #297).
  • tlsfun.de is a sanity check dependent on StartCom (see Replace StartCom-issued certs with certs from a different CA #296). Other providers (such as badssl.com and badtls.io) already offer similar tests to the ones we use from tlsfun.de.
  • expired.tlsfun.de tests the same things as e.g. expired.badtls.io and self-signed.badssl.com.
  • badcert-edell.tlsfun.de and superfish.tlsfun.de can be replaced with edellroot.badssl.com and superfish.badssl.com.

Closes #297. Closes #296.

@oherrala
Copy link
Member

Internets behave bad today, but PR LGTM.

@oherrala oherrala merged commit e78afe9 into master Oct 21, 2016
@oherrala
Copy link
Member

Thanks!

@oherrala oherrala deleted the remove-tests branch October 21, 2016 19:12
@jviide jviide mentioned this pull request Oct 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oherrala oherrala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviide @oherrala