Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update monolog.yaml so that migrate-db.sh will execute #455

Conversation

rkaiser0324
Copy link
Contributor

Upon following the directions to set up the Docker container, migrate-db.sh errors out as follows:

> docker-compose run --rm cron deploy/migrate-db.sh
[+] Running 1/0
 - Container wpackagist-db-1  Running                                                                              0.0s
[+] Running 1/1
 - Container wpackagist-cron-1  Started                                                                            0.9s
Running DB migrations...

In BaseNode.php line 469:

  Invalid configuration for path "monolog.handlers.main": You can only use excluded_http_codes/excluded_404s with a F
  ingersCrossedHandler definition


In ExprBuilder.php line 187:

  You can only use excluded_http_codes/excluded_404s with a FingersCrossedHandler definition


2022-05-13T15:45:30+00:00 [info] User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::getContainerExtension()" might add "?ExtensionInterface" as a native return type declaration in the future. Do the same in child class "BabDev\PagerfantaBundle\BabDevPagerfantaBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

I'm ignoring the deprecation warning.

This commit drops the 404 exclusion, allowing the command to proceed. I'm not familiar with monolog configurations but this may be related: symfony/monolog-bundle#309.

NoelLH added a commit that referenced this pull request May 18, 2022
@NoelLH
Copy link
Contributor

NoelLH commented May 18, 2022

Thanks and sorry @rkaiser0324 – it looks like I actually modified my local already while I was last looking at upgrades but never committed the new dev configuration.

My local keeps the excluded_404s but using the new config approach, which compared to removing the key means a more similar logging configuration to what we run in Production (where obviously it isn't crashing) – so I think to minimise avoidable configuration drift I'm going to apply that change instead. c5d0a09

Thank you for raising this though and sorry for slowing you down!

@NoelLH NoelLH closed this May 18, 2022
@rkaiser0324 rkaiser0324 deleted the fix/monolog-config-error branch May 18, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants