fix osc sdk go v2 migration and pointers #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-hmi
force-pushed
the
fixNetId
branch
from
fbfecb5
to
6365eb9
Compare
outscale-hmi
force-pushed
the
fixNetId
branch
7 times, most recently
from
6986e13
to
66e6c80
Compare
outscale-hmi
commented
Mar 9, 2023
builder/osc/common/block_device.go
Outdated
| @@ -114,12 +114,15 @@ func buildOscBlockDevicesVmCreation(b []BlockDevice) []oscgo.BlockDeviceMappingV | |||
| } | |||
|
|
|||
| if blockDevice.SnapshotId != "" { | |||
| log.Printf("snapshotId is nt nul ") | |||
outscale-mdr
requested changes
Mar 10, 2023
Comment on lines
133
to
134
| *device.Bsu.Iops = 0 | ||
| device.Bsu.SetIops(0) |
There was a problem hiding this comment.
If it is not an iops, do not set IOPS
There was a problem hiding this comment.
I would set nil pointer to the Iops variable
| @@ -146,16 +147,21 @@ func (s *StepRegisterOMI) combineDevices(snapshotIDs map[string]string) []oscgo. | |||
| } | |||
|
|
|||
| func copyToDeviceMappingImage(device osc.BlockDeviceMappingVmCreation) oscgo.BlockDeviceMappingImage { | |||
| log.Printf("Copydevice mapping image ") | |||
Comment on lines
154
to
155
| Iops: device.Bsu.Iops, | ||
| SnapshotId: device.Bsu.SnapshotId, |
There was a problem hiding this comment.
I think the previous code was the right thing to do. Just copy what you have. The big problem here is that device contains invalid data.
Comment on lines
160
to
165
| if device.Bsu.GetSnapshotId() != "" { | ||
| deviceImage.Bsu.SetSnapshotId(*oscgo.PtrString(*device.Bsu.SnapshotId)) | ||
| } | ||
| if device.Bsu.GetIops() != 0 { | ||
| deviceImage.Bsu.SetIops(*device.Bsu.Iops) | ||
| } |
There was a problem hiding this comment.
I would not do that, just copy the pointer
builder/osc/common/block_device.go
Outdated
| @@ -114,12 +114,15 @@ func buildOscBlockDevicesVmCreation(b []BlockDevice) []oscgo.BlockDeviceMappingV | |||
| } | |||
|
|
|||
| if blockDevice.SnapshotId != "" { | |||
| log.Printf("snapshotId is nt nul ") | |||
outscale-hmi
force-pushed
the
fixNetId
branch
2 times, most recently
from
1f66467
to
437286a
Compare
| @@ -154,6 +154,7 @@ func (s *StepNetworkInfo) Run(_ context.Context, state multistep.StateBag) multi | |||
| } | |||
| } | |||
|
|
|||
| ui.Message(fmt.Sprintf("NetId is null '%s'", s.NetId)) | |||
Comment on lines
126
to
128
| log.Printf("subregion is %s", subregion) | ||
| if subregion != "" { | ||
| log.Printf("placement subregion is %s", subregion) |
There was a problem hiding this comment.
Duplicate log, you can remove one of them
Signed-off-by: outscale_hmi <hanen.mizouni@outscale.com>
Signed-off-by: outscale_hmi <hanen.mizouni@outscale.com>
outscale-mdr
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.