upgrade sdk go from v1 to v2 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-hmi
force-pushed
the
upgradeSDK
branch
2 times, most recently
from
e44c1c8
to
95a5b6e
Compare
outscale-hmi
force-pushed
the
upgradeSDK
branch
from
95a5b6e
to
e750fd9
Compare
outscale-hmi
force-pushed
the
upgradeSDK
branch
2 times, most recently
from
dab8463
to
e7e6c48
Compare
outscale-mdr
requested changes
Dec 14, 2022
| if err != nil { | ||
| err := fmt.Errorf("Error searching for OMI: %s", err) | ||
| state.Put("error", err) | ||
| ui.Error(err.Error()) | ||
| return multistep.ActionHalt | ||
| } | ||
| s.image = &imagesResp.Images[0] | ||
| s.image = &imagesResp.GetImages()[0] |
There was a problem hiding this comment.
We could add a test if the array is empty (in case)
There was a problem hiding this comment.
What you add with the test "if the image is null" is good but check the size of the array before taking the first element.
if len(imagesResp.GetImages()) <= 0 {
err := fmt.Errorf("Error while reading the image': %s", err)
state.Put("error", err)
ui.Error(err.Error())
return multistep.ActionHalt
}
Comment on lines
96
to
101
| if awsErr, ok := err.(awserr.Error); ok { | ||
| if awsErr.Code() == "InvalidOMIID.NotFound" || | ||
| awsErr.Code() == "InvalidSnapshot.NotFound" { | ||
| return false, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
These will not work anymore, we could plan to update them
There was a problem hiding this comment.
I ll do it in a seperate PR
Comment on lines
77
to
78
| //params.Filters.SetAccountIds(oid) | ||
| //params.Filters.SetAccountAliases(oali) |
outscale-hmi
force-pushed
the
upgradeSDK
branch
3 times, most recently
from
d51428a
to
518ce81
Compare
outscale-mdr
requested changes
Jan 16, 2023
outscale-hmi
force-pushed
the
upgradeSDK
branch
2 times, most recently
from
02a5583
to
5f2023f
Compare
Signed-off-by: outscale_hmi <hanen.mizouni@outscale.com>
outscale-hmi
force-pushed
the
upgradeSDK
branch
from
5f2023f
to
f223e4b
Compare
outscale-mdr
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: outscale_hmi hanen.mizouni@outscale.com