add logs for mostRecent test #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mgo
requested changes
Oct 13, 2022
| state := new(multistep.BasicStateBag) | ||
| accessConfig := &AccessConfig{} | ||
| accessConfig.RawRegion = "eu-west-2" | ||
| var oscConn *osc.APIClient | ||
| var err error | ||
| if oscConn, err = accessConfig.NewOSCClient(); err != nil { | ||
| return nil | ||
| err := fmt.Errorf("error in creating osc Client") |
There was a problem hiding this comment.
err, is already set by accessConfig.NewOSCClient(), maybe you shouln't unset it here.
Or as last reuse it:
err := fmt.Errorf("error in creating osc Client: %s", err.Error() )
| if state == nil { | ||
| t.Fatalf("error retrieving state, but") | ||
| t.Fatalf("error retrieving state %s", err) |
There was a problem hiding this comment.
shouldn't you use err.Error() here ?
Signed-off-by: hanen mizouni <hanen.mizouni@outscale.com>
outscale-hmi
force-pushed
the
testUpdate
branch
from
8bb78c1
to
b17acfe
Compare
outscale-mgo
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hanen mizouni hanen.mizouni@outscale.com