Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:zlib: Brotli #10722

Merged
merged 34 commits into from
May 7, 2024
Merged

node:zlib: Brotli #10722

merged 34 commits into from
May 7, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented May 1, 2024

Closes #267

Copy link
Contributor

github-actions bot commented May 1, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

💻 2 failing tests Darwin x64 baseline

💻 3 failing tests Darwin x64

🐧💪 1 failing tests Linux AARCH64

🪟💻 8 failing tests Windows x64 baseline

🪟💻 9 failing tests Windows x64

View logs

src/js/node/zlib.ts Outdated Show resolved Hide resolved
@nektro nektro marked this pull request as ready for review May 2, 2024 21:24
@nektro nektro requested a review from Jarred-Sumner May 2, 2024 21:24
@nektro nektro marked this pull request as draft May 2, 2024 23:58
src/js/node/stream.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but very close to mergable

@nektro nektro marked this pull request as ready for review May 7, 2024 01:46
@nektro nektro requested a review from Jarred-Sumner May 7, 2024 02:36
src/js/node/zlib.ts Outdated Show resolved Hide resolved
src/js/node/zlib.ts Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit 1da810a into main May 7, 2024
40 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-15305 branch May 7, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No brotli in zlib
2 participants