New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Symbol.toStringTag to KeyObject instances #12278

Merged

Jarred-Sumner merged 1 commit into oven-sh:main from panva:keyobject-tostringtag

Jul 1, 2024

Contributor

panva commented Jul 1, 2024

What does this PR do?

As per nodejs/node#46043, this adds Symbol.toStringTag getter to KeyObject.


          fix: add Symbol.toStringTag to KeyObject instances

f9a41fb

Contributor

github-actions bot commented Jul 1, 2024

❌ @panva, your commit has failing tests :(

💻 1 failing tests Darwin x64 baseline

test/js/web/workers/worker.test.ts 1 failing

🪟💻 3 failing tests Windows x64 baseline

test/cli/install/registry/bun-install-registry.test.ts 3 failing
test/cli/install/registry/bun-install-windowsshim.test.ts code 1
test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 5 failing tests Windows x64

test/cli/install/registry/bun-install-registry.test.ts 1 failing
test/cli/install/registry/bun-install-windowsshim.test.ts code 1
test/js/bun/io/bun-write.test.js 1 failing
test/js/node/child_process/child_process.test.ts 1 failing
test/js/web/timers/setTimeout.test.js 1 failing

Collaborator

Jarred-Sumner commented Jul 1, 2024

I think these are all flaky tests

Jarred-Sumner merged commit 81711fa into oven-sh:main

48 of 52 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet