-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(child_process): add node:child_process polyfill #1424
feat(child_process): add node:child_process polyfill #1424
Conversation
Great start! |
Most of However after this, we will still lack IPC functionality. This is because we still need to add a check for a Many of the important use cases of I will give another update later after I get the node tests running and finish up spawnSync and the rest of the easy to finish exports. 👍 |
5b56a75
to
d6af33f
Compare
}); | ||
|
||
this.stdio = this.#getBunSpawnIo(bunStdio, options); | ||
this.stdin = this.stdio[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these might need to be getters so that the values are the same/not copied but i'm not 100% sure
}); | ||
|
||
this.stdio = this.#getBunSpawnIo(bunStdio, options); | ||
this.stdin = this.stdio[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these might need to be getters so that the values are in sync if the user assigns it but i'm not 100% sure
I'm going to go ahead and merge this! Great work. If the spawnSync issue isn't fixed we can fix it in a follow-up PR. |
Beginning of node:child_process polyfill, adds base case for spawn without any extra options specified, and the necessary functionality of the
ChildProcess
class.