Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our internal typedefs #3608

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Improve our internal typedefs #3608

merged 5 commits into from
Jul 12, 2023

Conversation

paperdave
Copy link
Member

@paperdave paperdave commented Jul 11, 2023

  • Add $putInternalField and $getInternalField (this is upcoming in my PR to our webkit fork)
  • Bun.lazy is a build-time define that converts to the symbol. This allows us to typedef it.
  • typo: remove unused code related to Bun.lazy("vm")
  • make init-submodules -> make submodule. and this no longer clones webkit which was a mistake of mine

I also commented how that lazy stuff works

@paperdave paperdave force-pushed the dave/internal-types branch 2 times, most recently from 30cc1a6 to 1477bbf Compare July 11, 2023 23:38
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

@paperdave 7 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_compile.test.ts
  • test/cli/install/bun-link.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#82b2f4be26e90afebd893119795bb1534766313e

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

@paperdave 4 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-link.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#82b2f4be26e90afebd893119795bb1534766313e

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

@paperdave 4 files with test failures on linux-x64:

  • test/cli/install/bun-link.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#82b2f4be26e90afebd893119795bb1534766313e

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

@paperdave 7 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-link.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#82b2f4be26e90afebd893119795bb1534766313e

@Jarred-Sumner Jarred-Sumner merged commit ae0a724 into main Jul 12, 2023
@Jarred-Sumner Jarred-Sumner deleted the dave/internal-types branch July 12, 2023 22:21
Jarred-Sumner pushed a commit that referenced this pull request Jul 13, 2023
* types

* some more

* yeah

* i think that fixes it

* oop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants