-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve our internal typedefs #3608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
force-pushed
the
dave/internal-types
branch
2 times, most recently
from
July 11, 2023 23:38
30cc1a6
to
1477bbf
Compare
❌ @paperdave 7 files with test failures on bun-darwin-aarch64:
|
❌ @paperdave 4 files with test failures on linux-x64-baseline:
|
❌ @paperdave 4 files with test failures on linux-x64:
|
❌ @paperdave 7 files with test failures on bun-darwin-x64-baseline:
|
paperdave
force-pushed
the
dave/internal-types
branch
from
July 12, 2023 19:59
2b3e927
to
de3fceb
Compare
Jarred-Sumner
pushed a commit
that referenced
this pull request
Jul 13, 2023
* types * some more * yeah * i think that fixes it * oop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$putInternalField
and$getInternalField
(this is upcoming in my PR to our webkit fork)Bun.lazy
is a build-time define that converts to the symbol. This allows us to typedef it.Bun.lazy("vm")
I also commented how that lazy stuff works