Throw/Unwrap PHP7 \Error in await() #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpastoor
force-pushed
the
jpastoor/throwable-await
branch
from
879fa98 to
9356d81
Compare
|
CI seems to fail on an unrelated issue while selfupdating composer. |
|
Would it be possible to get a review on this @mcg-web ? |
mcg-web
approved these changes
Jul 10, 2020
|
hhvm support will be drop so no need to make it work |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Checks for the existence of the Throwable interface, and allows throwing of Errors while unwrapping the rejectedReason.