Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mixed keys #59

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Allow mixed keys #59

merged 1 commit into from
Feb 16, 2022

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 16, 2022

My cache allows keys of any type. Can we narrow the type of key?

@codecov-commenter
Copy link

Codecov Report

Merging #59 (ac2e757) into master (4347804) will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   56.61%   57.53%   +0.91%     
==========================================
  Files           7        7              
  Lines         325      332       +7     
==========================================
+ Hits          184      191       +7     
  Misses        141      141              
Impacted Files Coverage Δ
src/Option.php 100.00% <0.00%> (ø)
...romise-adapter/src/Adapter/ReactPromiseAdapter.php 0.00% <0.00%> (ø)
...e-adapter/src/Adapter/GuzzleHttpPromiseAdapter.php 0.00% <0.00%> (ø)
...r/src/Adapter/WebonyxGraphQLSyncPromiseAdapter.php 0.00% <0.00%> (ø)
src/DataLoader.php 99.33% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264e38a...ac2e757. Read the comment docs.

@mcg-web
Copy link
Member

mcg-web commented Feb 16, 2022

Look good to me. Thank you @simPod !

@mcg-web mcg-web merged commit 333f5eb into overblog:master Feb 16, 2022
@simPod simPod deleted the key-mixed branch February 16, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants