Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to wait if new instances of dataloader were declared during the processing #8

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Added fix to wait if new instances of dataloader were declared during the processing #8

merged 1 commit into from
Jan 20, 2017

Conversation

OwlyCode
Copy link
Contributor

@OwlyCode OwlyCode commented Jan 20, 2017

This fix solves the awaitInstances method for cases like this :

$dataloader->load(1)->then(function () {
    $subLoader = new DataLoader(...);
    $subLoader->load(2);
});

Without the fix, awaitInstances() would stop on the first dataloader, ignoring the second one.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) to 98.925% when pulling 22dc047 on OwlyCode:wait-new-instances into 6cb2023 on overblog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 982077b2c35dd6870997254d3670161d776c76c8 on OwlyCode:wait-new-instances into 6cb2023 on overblog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0fa6535 on OwlyCode:wait-new-instances into 6cb2023 on overblog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0fa6535 on OwlyCode:wait-new-instances into 6cb2023 on overblog:master.

@mcg-web mcg-web merged commit 55836c8 into overblog:master Jan 20, 2017
@mcg-web
Copy link
Member

mcg-web commented Jan 20, 2017

Thank you for the fix 👍

@OwlyCode OwlyCode deleted the wait-new-instances branch January 20, 2017 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants