Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-op eh_personality function to silence CI errors #142

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

ayrtonm
Copy link
Contributor

@ayrtonm ayrtonm commented Sep 11, 2022

This adds a no-op implementation for the eh_personality function to silence the daily CI error messages on discord. I believe catching panics is still kinda iffy when using lld, so this shouldn't break anything in the default case.

Also I tried porting over the version from rust to the psp crate, but it's not completely trivial since it depends on the unwind crate in rust (this is different from the one on crates.io). There was also talk of moving it to a new crate in the rust PR that broke CI, so that might be a better option.

@ayrtonm
Copy link
Contributor Author

ayrtonm commented Sep 12, 2022

So the build-rust and build-rust-macos tasks are failing with

error[E0152]: found duplicate lang item `eh_personality` 

because it says eh_personality is also in the panic_unwind crate. I'm not sure if it's an issue because they're not testing with a recent enough compiler or if something's being cached.

@sajattack
Copy link
Collaborator

sajattack commented Sep 12, 2022

Probably build-rust and build-rust-macos need a compiler update. https://github.com/overdrivenpotato/rust-psp/blob/master/ci/concourse/build-rust.yml#L14 Update the readme and cargo-psp too please with the new MSRV.

@ayrtonm
Copy link
Contributor Author

ayrtonm commented Sep 12, 2022

Thanks for pointing that out, I'd just assumed everything was testing with nightly. I updated the README too.

edit: Just updated cargo-psp as well.

@ayrtonm ayrtonm force-pushed the eh_personality branch 4 times, most recently from 0a7e232 to 67f25a6 Compare September 13, 2022 13:01
This is required since adding the no-op personality function breaks older
versions of rust which have `eh_personality` in the `panic_unwind` crate.
@ayrtonm
Copy link
Contributor Author

ayrtonm commented Sep 13, 2022

Not sure how this was actually working before since the cargo-psp commit date previously matched the nightly used in CI, but I think I got the CI problem figured out.

@sajattack sajattack merged commit 09126e9 into overdrivenpotato:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants