refactor: remove unused import and rename S3Boto3Storage constructor param #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@regisb could you please review this one? |
regisb
reviewed
Jun 21, 2023
openedxscorm/storage.py
Outdated
| @@ -18,7 +17,7 @@ def __init__(self, xblock, bucket, querystring_auth, querystring_expire): | |||
| # No need to serve assets from a custom domain. | |||
| self.custom_domain = None | |||
| super().__init__( | |||
| bucket=bucket, | |||
| bucket_name=bucket, | |||
There was a problem hiding this comment.
Can you please also modify the S3ScormStorage constructor signature such that it matches the super constructor?
def __init__(self, xblock, bucket_name=None, querystring_auth=None, querystring_expire=None):
ziafazal
force-pushed
the
ziafazal/change-bucket-name-param
branch
from
3a89ef9 to
20521a1
Compare
regisb
reviewed
Jun 21, 2023
…param refactor: match contructors refactor: reviewer feedback changes
ziafazal
force-pushed
the
ziafazal/change-bucket-name-param
branch
from
20521a1 to
18abe7a
Compare
regisb
approved these changes
Jun 22, 2023
|
Thanks for the PR! |
|
@regisb can you please release the new version ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has couple of changes to
bucketparam in S3Boto3Storage constructor tobucket_namesince it is removed since 1.10. This change does not break anything in older(1.9) version of django-storages.