Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated pkg_resources package with importlib_resources #68

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

ahmed-arb
Copy link
Contributor

@ahmed-arb ahmed-arb commented Mar 14, 2024

Removed pkg_resources for compatibility with newer python versions as discussed in this issue.

Ensured that this xblock is working with python 3.12 & 3.8 as mentioned in this issue.

@ahmed-arb
Copy link
Contributor Author

@ziafazal could you please take a look at his?

Copy link
Collaborator

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmed-arb thanks for PR. I have a question.

openedxscorm/scormxblock.py Outdated Show resolved Hide resolved
@ahmed-arb ahmed-arb requested a review from ziafazal March 15, 2024 06:41
Copy link
Collaborator

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ziafazal ziafazal merged commit ff587d3 into overhangio:master Mar 18, 2024
@regisb regisb deleted the ahmed-arb/python3.12-compatible branch March 26, 2024 11:09
ziafazal pushed a commit that referenced this pull request May 27, 2024
* fix: remove pkg_resources for compatibility with python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants