feat: generalize proxy assets for use with every storage #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this so that custom storage does not need to be defined for Scorm The default storage configured for Open edX should work out of the box with scorm now This also fixes an issue of X-Frame-Options on the LMS when running in development mode closes overhangio#87
timmc-edx
reviewed
Nov 6, 2024
| @@ -765,7 +764,7 @@ def find_file_path(self, filename): | |||
| Search recursively in the extracted folder for a given file. Path of the first | |||
| found file will be returned. Raise a ScormError if file cannot be found. | |||
| """ | |||
| path = self.get_file_path(filename, self.extract_folder_path) | |||
| path = self.get_file_path(filename, self.extract_folder_path) or self.get_file_path(filename, self.extract_folder_base_path) | |||
There was a problem hiding this comment.
Is this part needed for generalizing asset serving? (Not entirely sure what the effect of this line is.) It looks like it would fall back to searching across all upload-versions of the same scorm xblock.
There was a problem hiding this comment.
We need this for backwards compatibility as older versions of scorm would store files in the base path. We also need this as we have modified the index_page_url property.
There was a problem hiding this comment.
I see, thanks! And find_file_path is now invoked from assets_proxy.
timmc-edx
approved these changes
Nov 20, 2024
andrii-hantkovskyi
pushed a commit
to raccoongang/openedx-scorm-xblock
that referenced
this pull request
Dec 18, 2024
* feat: generalize proxy assets for use with every storage We do this so that custom storage does not need to be defined for Scorm The default storage configured for Open edX should work out of the box with scorm now This also fixes an issue of X-Frame-Options on the LMS when running in development mode closes overhangio#87 Co-authored-by: Tim McCormack <tmccormack@edx.org> --------- Co-authored-by: Tim McCormack <tmccormack@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87