refactor: address comments

overhangio · Jul 1, 2024 · a40d767 · a40d767
1 parent e7cee67
commit a40d767
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/tutordiscovery/patches/local-docker-compose-dev-services b/tutordiscovery/patches/local-docker-compose-dev-services
@@ -5,7 +5,7 @@ discovery:
   stdin_open: true
   tty: true
   volumes:
-    - ../../data/discovery-media:/openedx/discovery/course_discovery/media
+    - ../../data/discovery/media:/openedx/discovery/course_discovery/media
   {%- for mount in iter_mounts(MOUNTS, "discovery") %}
     - {{ mount }}
   {%- endfor %}

diff --git a/tutordiscovery/patches/local-docker-compose-services b/tutordiscovery/patches/local-docker-compose-services
@@ -5,7 +5,7 @@ discovery:
   restart: unless-stopped
   volumes:
     - ../plugins/discovery/apps/settings/tutor:/openedx/discovery/course_discovery/settings/tutor:ro
-    - ../../data/discovery-media:/openedx/discovery/course_discovery/media
+    - ../../data/discovery/media:/openedx/discovery/course_discovery/media
   depends_on: 
     - lms
     {% if RUN_MYSQL %}- mysql{% endif %}

diff --git a/tutordiscovery/templates/discovery/build/discovery/Dockerfile b/tutordiscovery/templates/discovery/build/discovery/Dockerfile
@@ -86,10 +86,7 @@ COPY --chown=app:app assets.py ./course_discovery/settings/assets.py
 RUN DJANGO_SETTINGS_MODULE=course_discovery.settings.assets make static
 
 # Create media directory to serve media files
-# have to change user at this step, as it gives permission error
-User app
 RUN mkdir course_discovery/media
-User root
 
 # Run production server
 ENV DJANGO_SETTINGS_MODULE=course_discovery.settings.tutor.production