fix: append trailing slash to PUBLIC_PATH #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts ae60b2d. We depend heavily on Webpack's `publicPath` for everything to work in MFEs that are hosted in sub-paths. This variable affects many things, including URLs that are automatically generated for things like static assets or lazily loaded chunks of code. If the trailing slash is not appended to, say, `/learning`, a React.lazy() will try to fetch this from Caddy, and fail: `/learning210.3f8d0b2a9dbf3b1f1e69.js` While this can (and probably should) be dealt with in frontend-platform, we do it here for now.
|
@regisb, this is also necessary for Quince. Is nightly going to be pulled in again before release, or should I create a backport? |
This was referenced Dec 6, 2023
Closed
|
No worries, I'll rebase the Quince branch right on top of nightly after we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts ae60b2d. We depend heavily on Webpack's
publicPathfor everything to work in MFEs that are hosted in sub-paths. This variable affects many things, including URLs that are automatically generated for things like static assets or lazily loaded chunks of code. If the trailing slash is not appended to, say,/learning, a React.lazy() will try to fetch this from Caddy, and fail:/learning210.3f8d0b2a9dbf3b1f1e69.jsWhile this can (and probably should) be dealt with in frontend-platform, we do it here for now.