feat: add atlas pull support - FC-0012 #950
Conversation
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.atlas-pull
branch
from
27a7755
to
241a757
Compare
|
Please review @OmarIthawi , @regisb |
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.atlas-pull
branch
2 times, most recently
from
3f45451
to
8bb6a47
Compare
| @@ -187,6 +187,13 @@ ENV REVISION_CFG /openedx/config/revisions.yml | |||
| COPY --chown=app:app settings/lms/*.py ./lms/envs/tutor/ | |||
| COPY --chown=app:app settings/cms/*.py ./cms/envs/tutor/ | |||
|
|
|||
| {% if OPENEDX_ATLAS_PULL %} | |||
| # Support the OEP-58 proposal behind a feature flag until it's fully implemented | |||
| RUN pip install openedx-atlas | |||
There was a problem hiding this comment.
openedx-atlas is not being installed by default yet, so we need to install it here when the flag is set
There was a problem hiding this comment.
openedx-atlas==0.5.0 is already installed on master: https://github.com/openedx/edx-platform/blob/master/requirements/edx/base.txt#L781
Do we still need this pip install?
There was a problem hiding this comment.
@shadinaif now nightly should be tracking quince and atlas is installed on open-release/quince.master:
|
Blocked, pending an answer to my comment: overhangio/tutor-credentials#22 (review) |
| @@ -187,6 +187,13 @@ ENV REVISION_CFG /openedx/config/revisions.yml | |||
| COPY --chown=app:app settings/lms/*.py ./lms/envs/tutor/ | |||
| COPY --chown=app:app settings/cms/*.py ./cms/envs/tutor/ | |||
|
|
|||
| {% if OPENEDX_ATLAS_PULL %} | |||
| # Support the OEP-58 proposal behind a feature flag until it's fully implemented | |||
| RUN pip install openedx-atlas | |||
There was a problem hiding this comment.
openedx-atlas==0.5.0 is already installed on master: https://github.com/openedx/edx-platform/blob/master/requirements/edx/base.txt#L781
Do we still need this pip install?
| @@ -159,7 +159,7 @@ USER ${APP_USER_ID} | |||
| # https://hub.docker.com/r/powerman/dockerize/tags | |||
| COPY --link --from=docker.io/powerman/dockerize:0.19.0 /usr/local/bin/dockerize /usr/local/bin/dockerize | |||
| COPY --chown=app:app --from=edx-platform / /openedx/edx-platform | |||
| COPY --chown=app:app --from=locales /openedx/locale /openedx/locale | |||
| {% if not OPENEDX_ATLAS_PULL %}COPY --chown=app:app --from=locales /openedx/locale /openedx/locale{% endif %} | |||
There was a problem hiding this comment.
Do we really need to disable /openedx/locale? It seems that in the edxapp both atlas pull and /openedx/locale can work together without an issue because it's depending on the LOCALE_PATHS variable which accepts multiple directories.
There was a problem hiding this comment.
@shadinaif please revert those lines if the PR can work okay with them.
There was a problem hiding this comment.
Technically they can work together. Done!
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.atlas-pull
branch
3 times, most recently
from
c57df64
to
bc27220
Compare
Add atlas pull behind a feature flag until it's fully implemented Refs: FC-0012 OEP-58
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.atlas-pull
branch
from
bc27220
to
26ea636
Compare
|
@shadinaif please hold off until #964 is merged. We're refactoring Atlas integration with Tutor a bit. |
|
closing as decided here |
openedx-i18ntranslation files when atlas feature is activatedBackground
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.