Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove only tls1.1 #43

Closed
wants to merge 1 commit into from
Closed

remove only tls1.1 #43

wants to merge 1 commit into from

Conversation

7hunderbird
Copy link
Collaborator

I first experimented with the version of CloudFront's terraform module in PR #42, then changed it to try taking away the TLS v1.1 option in the origin resource.

This PR looks to see what is different in the state of the GitHub Actions state when I change only the TLS 1.1.

I'm curious about both how Overmind itself handles the "state" of the system, as well as understanding how GitHub Actions affects the results of Overmind. I would expect that there isn't shared state between each build on GitHub Actions, and this would help me validate that assumption.

Copy link

mapped Expected Changes

updated cloudfront-distribution › E15V1JM5GZXBKB
--- current
+++ planned
@@ -95,22 +95,21 @@
       custom_header: []
       custom_origin_config: []
       domain_name: s3-one-apt-catfish.s3.eu-west-2.amazonaws.com
-      origin_access_control_id: ""
-      origin_id: s3_one
+      origin_access_control_id: E23BFWHZQZKBPZ
+      origin_id: s3_oac
       origin_path: ""
       origin_shield: []
-      s3_origin_config:
-        - origin_access_identity: origin-access-identity/cloudfront/E2X23HICB2NVF3
+      s3_origin_config: []
     - connection_attempts: 3
       connection_timeout: 10
       custom_header: []
       custom_origin_config: []
       domain_name: s3-one-apt-catfish.s3.eu-west-2.amazonaws.com
-      origin_access_control_id: E23BFWHZQZKBPZ
-      origin_id: s3_oac
+      origin_id: s3_one
       origin_path: ""
       origin_shield: []
-      s3_origin_config: []
+      s3_origin_config:
+        - origin_access_identity: origin-access-identity/cloudfront/E2X23HICB2NVF3
     - connection_attempts: 3
       connection_timeout: 10
       custom_header:
@@ -126,7 +116,6 @@
           origin_read_timeout: 30
           origin_ssl_protocols:
             - TLSv1
-            - TLSv1.1
             - TLSv1.2
       domain_name: appsync.terraform-aws-modules.modules.tf
       origin_access_control_id: ""

Blast Radius

items Items edges Edges
113 108

Open in Overmind

@dylanratcliffe dylanratcliffe deleted the no-tls1.1 branch January 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants