Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated port to 8888 for health checks #46

Closed
wants to merge 1 commit into from
Closed

Updated port to 8888 for health checks #46

wants to merge 1 commit into from

Conversation

DavidS-ovm
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 2, 2024

mapped Expected Changes

replaced ecs-task-definition › facial-recognition
--- current
+++ planned
@@ -1,26 +1,16 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition:46
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition
-container_definitions: '[{"cpu":1024,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:8080"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"volumesFrom":[]}]'
+container_definitions: '[{"cpu":1024,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:8888"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]'
 cpu: "1024"
 ephemeral_storage: []
-execution_role_arn: ""
 family: facial-recognition
-id: facial-recognition
 inference_accelerator: []
-ipc_mode: ""
 memory: "2048"
 network_mode: awsvpc
-pid_mode: ""
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 46
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
 terraform_address: module.loom[0].aws_ecs_task_definition.face
 terraform_name: module.loom[0].aws_ecs_task_definition.face
 volume: []
replaced ecs-task-definition › visit-counter
--- current
+++ planned
@@ -1,26 +1,16 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter:20
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter
-container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80,"hostPort":80,"protocol":"tcp"}],"volumesFrom":[]}]'
+container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:8888 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80}],"volumesFrom":[]}]'
 cpu: "256"
 ephemeral_storage: []
-execution_role_arn: ""
 family: visit-counter
-id: visit-counter
 inference_accelerator: []
-ipc_mode: ""
 memory: "512"
 network_mode: awsvpc
-pid_mode: ""
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 20
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
 terraform_address: module.loom[0].aws_ecs_task_definition.visit_counter
 terraform_name: module.loom[0].aws_ecs_task_definition.visit_counter
 volume: []

Blast Radius

items Items edges Edges
127 130

Open in Overmind

warning Risks

high Health Check Command Misconfiguration for 'face' Service [High]

The health check for the 'face' service ECS task definition is set to be updated to use port 8888, as per the change. However, the current state of the facial-recognition ECS service shows container definitions with a containerPort of 1234, and the associated load balancer health checks are targeting the same port. If the application is not configured to listen on port 8888, ECS will fail the health checks resulting in task restarts and potential service disruption.

high Health Check Command Misconfiguration for 'visit_counter' Service [High]

The task definition changes for the 'visit_counter' service move the health check of the container from port 80 to 8888. However, the current live task definition and the related Elastic Load Balancer's (ELB) target group health check configuration suggests that the service's container and the ELB health check are both expecting the container to respond on port 80. A misaligned port configuration will cause the health check to fail, possibly leading ECS to stop and start tasks repeatedly, causing downtime.

@dylanratcliffe dylanratcliffe deleted the example branch January 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants