Update Terraform terraform-aws-modules/s3-bucket/aws to v4

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
terraform-aws-modules/s3-bucket/aws (source)	module	major	~> 3.0 -> ~> 4.0

---

Release Notes

terraform-aws-modules/terraform-aws-s3-bucket (terraform-aws-modules/s3-bucket/aws)

v4.0.1

Compare Source

v4.0.0

Compare Source

⚠ BREAKING CHANGES

• upd versions.tf to require >= 5.27

Features

• logging: change logging variable type to any (2c45bde)
• logging: Date based partitioning for access-logs (59f65af)
• upd versions.tf to require >= 5.27 (7a4aab6)

3.15.2 (2024-01-12)

Bug Fixes

• Add China regions to elb_service_accounts (#​264) (c6870d5)

3.15.1 (2023-08-26)

Bug Fixes

• Added missing check for attach_access_log_delivery_policy for access logs logic (#​252) (97e542b)

---

Configuration

📅 Schedule: Branch creation - "before 4pm on friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[github-actions]

Expected Changes

No expected changes found.

Blast Radius

Items	Edges
0	0

Open in Overmind

Risks

Major Version Upgrade of Terraform S3 Module [High]

Upgrading the Terraform S3 module from version 3.x to 4.x could introduce breaking changes due to changes in the module's API or behavior. Given that there is no additional information provided about the current state of the system, the risk assessment remains unchanged. The module's changelog should be reviewed to identify any incompatible changes, and thorough testing in a non-production environment is advised to ensure that there will be no unexpected disruptions. Testing should be comprehensive, covering not only terraform plan and terraform apply but also the actual operation of applications using the S3 bucket for full confidence.

Potential Data Loss from Forced Bucket Destruction [Medium]

The force_destroy parameter is set to true, which can cause all contents within the S3 bucket to be permanently deleted if the bucket is destroyed. Considering that the current configuration is operational, this risk remains relevant because the module upgrade could potentially mandate bucket recreation. To mitigate this risk, backups should be in place, and the exact behavior of the new module version regarding bucket recreation should be confirmed during testing.