Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to port 88 #57

Closed
wants to merge 1 commit into from
Closed

Update to port 88 #57

wants to merge 1 commit into from

Conversation

dylanratcliffe
Copy link
Member

As per ticket #12345

As per ticket #12345
Copy link

mapped Expected Changes

replaced ecs-task-definition › visit-counter
--- current
+++ planned
@@ -1,26 +1,16 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter:20
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter
-container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80,"hostPort":80,"protocol":"tcp"}],"volumesFrom":[]}]'
+container_definitions: '[{"cpu":256,"environment":[],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:88 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80}],"volumesFrom":[]}]'
 cpu: "256"
 ephemeral_storage: []
-execution_role_arn: ""
 family: visit-counter
-id: visit-counter
 inference_accelerator: []
-ipc_mode: ""
 memory: "512"
 network_mode: awsvpc
-pid_mode: ""
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 20
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
 terraform_address: module.loom[0].aws_ecs_task_definition.visit_counter
 terraform_name: module.loom[0].aws_ecs_task_definition.visit_counter
 volume: []

Blast Radius

items Items edges Edges
112 115

Open in Overmind

warning Risks

high Potential Health Check Failure Due to Port Update [High]

The PR changes the container health check command to check port 88 instead of port 80 (CMD-SHELL, curl -f http://localhost:88 || exit 1). The current task definition and related load balancer configuration use port 80, as seen in the ec2-network-interface and elbv2-listener resources which are actively using port 80. If the container is not listening on port 88, the health check will fail, and ECS may continually restart the visit-counter service, causing service disruption.

high Load Balancer Configuration Mismatch [High]

The load balancer is configured to forward traffic to port 80 (ec2-network-interface, elbv2-listener, and elbv2-target-group for visit-counter). If the application within the container is now expecting traffic on port 88, this will lead to failures as the load balancer is not aware of this change. It's essential to ensure that the load balancer configuration is updated accordingly to avoid service disruption.

high Incorrect or Partial Update to Container and Load Balancer Port Configuration [High]

While the health check port is updated in the ECS task definition, there is no corresponding update to the container port mapping and load balancer target group configuration. This indicates a risk that the application and load balancer are not configured to use the new port 88 which would result in failed health checks and no traffic being routed to the service.

@dylanratcliffe dylanratcliffe deleted the dylanratcliffe-patch-1 branch January 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant