-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ref_from
from
#123
Comments
@peterwvj can you confirm whether there is any situation currently where the code generator emits anything other than |
@bandurvp it should all be contained in the GC transformation yes. |
Right, and in there there is no case in which it emits something like |
I'm pretty sure we got rid of all of that at one point. We only pass |
Hi @peterwvj , I want to attempt to remove all traces of |
Hi @bandurvp . I don't think there's anything else to consider, but I could be wrong. Wouldn't it be better/safer to simply remove the "NULL parameter" from the function definitions in the runtime (rather than duplicating them). Otherwise the approach sounds fine. |
That would be the final approach, I was just thinking that this would be just a way of organizing the change. But if I think about it there isn't really an advantage to it, thanks! I'll let you know how things come out. Can I merge your branch into development and branch from there? |
Yes, absolutely 👌 |
If the current GC approach is to pass
NULL
asref_from
then remove it fromTVP
.The text was updated successfully, but these errors were encountered: