Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default color list used for the Biome Overlay. #1972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poempelfox
Copy link

Instead of the old, only partially complete and illogical default scheme, we now use the same one as Amidst.

The old default color scheme only contained a fraction of the available biomes, it seems it hasn't been updated for newer minecraft versions in ages. At first I tried to fill in the gaps by selecting colors myself to match the existing ones, but I was soon pulling my hair out, because there seemed to be no logic in these color choices. So instead, I threw it all away and just used the color scheme from the Amidst project that they describe in https://github.com/toolbox4minecraft/amidst/wiki/Biome-Color-Table . That scheme does seem to have a certain logic (e.g. the colors of similar biomes are similar), and it also seems to be sort of a de facto standard - e.g. the chunkbase seedmap uses it too.

While no code was directly copied, so IMHO their GPL3 license does not apply, I only found it fair to give them credit - which I did in both the source code and the documentation.

Instead of the old, only partially complete and illogical default
scheme, we now use the same one as Amidst.
@fireduck64
Copy link

Does this fix the biome color issue here? #2022

I am just a user and noticed some work in that ticket and this PR want am worried they are not working together.

@poempelfox
Copy link
Author

Does this fix the biome color issue here?

It most certainly does not, because it hasn't got the slightest thing to do with biome tinting, and is from MC 1.17 times.

The biome overlay is affected by the same problem with MC 1.18 though, and will not recognize any biome in files written by MC 1.18 because the file format seems to have changed.
Even after the general problems with MC 1.18 files have been fixed and this PR has been merged, there will need to be another update to support MC 1.18 for biome overlays, because that version has essentially renumbered most biomes.

Atten007 added a commit to Atten007/Minecraft-Overviewer that referenced this pull request Apr 11, 2022
Atten007 added a commit to Atten007/Minecraft-Overviewer that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants