Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark chunks - addresses #2029 and #1899, prepares for fix of #2002, #2024, and #2035 #2060

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dark chunks - addresses #2029 and #1899, prepares for fix of #2002, #2024, and #2035 #2060

wants to merge 2 commits into from

Commits on Jul 28, 2022

  1. Fullbright overworld chunks without skylight 

    Chunks that don't contain a single section with sky light will now be
fullbrighted, eg, skylight will be set to full for the entire chunk.

This commit also refactors how light data is extracted and reshaped in
order to make the code more efficient and maintainable.
    @ralokt
    ralokt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d521770 View commit details
    Browse the repository at this point in the history

  2. Fullbright chunks without full sky light 

    This commit also fully brightens chunks that contain sky light, but
are mostly dark.

Minecraft will sometimes partially generate sky light in chunks that
is just spillover from neighboring chunks, but doesn't take the chunk
itself into account, leaving us with a mostly dark chunk.

Now, we check the sky light data and fully brighten chunks without a
single block of full skylight.
    @ralokt
    ralokt committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    57727ae View commit details
    Browse the repository at this point in the history