Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resource/datasource ovh_ip_firewall #596

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

amstuta
Copy link
Contributor

@amstuta amstuta commented Mar 29, 2024

Description

Add resource and datasource ovh_ip_firewall.

Related to #216

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccIPFirewall_data"
  • Test B: make testacc TESTARGS="-run TestAccIPFirewall_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta amstuta force-pushed the dev/aamstutz/generate-ip-routes branch from 153f101 to 2393b2b Compare March 29, 2024 15:34
deathiop
deathiop previously approved these changes Mar 29, 2024
website/docs/d/ip_firewall.html.markdown Outdated Show resolved Hide resolved
website/docs/d/ip_firewall.html.markdown Outdated Show resolved Hide resolved
website/docs/r/ip_firewall.html.markdown Outdated Show resolved Hide resolved
website/docs/r/ip_firewall.html.markdown Outdated Show resolved Hide resolved
Co-authored-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@rbeuque74 rbeuque74 merged commit cbb97ea into master Mar 29, 2024
@rbeuque74 rbeuque74 deleted the dev/aamstutz/generate-ip-routes branch March 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants