This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Explicitly use version 3 of the API #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scrat14, please review. |
Veersion 4 of the oVirt engine will support two versions of the API: version 3, which will be backwards compatible with older versions of the engine and version 4, which won't be compatible. The default used by the server will be version 4, but clients can explicitly request a version of the API using the "Version" header or the "/v3" URL prefix. The header is the preferred mechanism because it is just ignored by older versions of the server. This patch modifies the the "check_rhev3.pl" script so that it always send the header explicitly, so that it will work with version 4 of the engine. Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
|
Not sure if I changed all the places where requests are sent. Any suggestion? |
|
Thanks a lot for the patch, Juan! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Veersion 4 of the oVirt engine will support two versions of the API:
version 3, which will be backwards compatible with older versions of the
engine and version 4, which won't be compatible. The default used by the
server will be version 4, but clients can explicitly request a version
of the API using the "Version" header or the "/v3" URL prefix. The
header is the preferred mechanism because it is just ignored by older
versions of the server. This patch modifies the the "check_rhev3.pl"
script so that it always send the header explicitly, so that it will
work with version 4 of the engine.
Signed-off-by: Juan Hernandez juan.hernandez@redhat.com