dual-stack support for l3-gateway-config annotation #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danwinship needs rebase due to other merges. |
danwinship
force-pushed
the
dual-stack-gateway
branch
2 times, most recently
from
9ae5840
to
8317cf2
Compare
Signed-off-by: Dan Winship <danw@redhat.com>
Signed-off-by: Dan Winship <danw@redhat.com>
Also make the caller set the chassis ID explicitly (like it was originally), for consistency on set vs get. Signed-off-by: Dan Winship <danw@redhat.com>
danwinship
force-pushed
the
dual-stack-gateway
branch
from
8317cf2
to
301cd52
Compare
|
danwinship
force-pushed
the
dual-stack-gateway
branch
from
301cd52
to
88b457c
Compare
Signed-off-by: Dan Winship <danw@redhat.com>
danwinship
force-pushed
the
dual-stack-gateway
branch
from
88b457c
to
47eb99c
Compare
|
@dcbw this one is green now |
|
/lgtm |
kyrtapz
pushed a commit
to kyrtapz/ovn-kubernetes
that referenced
this pull request
Jan 9, 2023
Update base image of Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds dual-stack support to the setting and parsing of the l3-gateway-config annotation (but not rippling much beyond that).
Similarly to the pod annotation, I've added new array-valued
ip-addressesandnext-hopsto replaceip-addressandnext-hop, and we set both fields in single-stack clusters but only the new fields in dual-stack clusters; eventually we can migrate to only setting the new fields everywhere.node_annotations.gogets mostly rewritten but the new unit test shows that it's a no-op except where expected.This also updates one of our external-ids in ovn similarly.
@dcbw