-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual Stack OVN-Kubernetes job #1520
Conversation
Results here, it is working |
/assign @dcbw
It's working the job , not all the tests 🙃 |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Add a dual stack job that runs periodically. It's also possible to run the job on demand. This is just needed to give signal, since some of the tests are known to fail. Once it is stable we should add a premerge job. Signed-off-by: Antonio Ojea <aojea@redhat.com>
/lgtm |
yeah lgtm too. I don't really know the CI setup stuff though |
So this just runs periodic job on master? Why would we limit it to just dual-stack? For the IPv6 CI PR, I limited the test matrix just to reduce the test time for each PR. The periodic run could test those additional matrix items in the background for sanity. |
1 step at a time 😄 we can add more periodic jobs later, we just need dual stack ASAP also, @Billy99 , if we merge this #1500, we can enable more combinations on presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just a few questions.
run: | | ||
docker load --input image.tar | ||
|
||
- name: kind setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be replaced with install-kind.sh
at some time in the future? Assume you need additional patches to KIND for dual-stack (https://github.com/aojea/kind/releases/download/dualstack/kind).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but right now is a chicken an egg problem, we need to stabilize dual-stack first.
This way we avoid any risk of affecting other things in the repo, and allows us to have signal on master
@@ -0,0 +1,226 @@ | |||
name: ovn-ci-periodic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this file have to always be separate from test.yml? Always get nervous when there is a lot the same or real similar logic in two places and trying to make sure they stay in synch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as in here #1520 (comment)
until it is stable, I expect lot of churn in this file, we can do any changes here without impacting the rest of the jobs
@aojea I'll merge becuase we have a bunch of LGTMs, but can you answer Billy's questions too? Thanks! |
…e-snat-4.12 OCPBUGS-7317: [release-4.12] Delete stale egress ip snat entries by node
- What this PR does and why is it needed
Set up a periodic job to test dual stack
- Special notes for reviewers
This does not affect merging, since the job added runes periodically and is only informative
- How to verify it
You can see an example of how it runs here
https://github.com/aojea/ovn-kubernetes/actions/runs/184296553
- Description for the changelog