cache: Return IndexExistsError immediately #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't put them in an array of errs and return that because it can't be type asserted back to IndexExistsError Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
/cc @jcaamano thanks for finding this one! |
Pull Request Test Coverage Report for Build 989766351
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't put them in an array of errs and return that because it can't be
type asserted back to IndexExistsError and, in turn, won't manifest as an
ovsdb.ConstraintViolationin the client.Signed-off-by: Dave Tucker dave@dtucker.co.uk