Makefile: Add missing dependency to test target #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following issue when making test:
make test ; echo $?
...
PASS
coverage: [no statements]
ok github.com/ovn-org/libovsdb/test/ovs 0.030s coverage: [no statements]
make: *** [Makefile:20: test] Error 2
2
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
Pull Request Test Coverage Report for Build 1034978965
💛 - Coveralls |
|
@jcaamano @dave-tucker The reason CI is happy is because prebuild is explicitly done in the workflow. So this change is just making that step part of the Makefile target. So an outstanding question is: do you think that the should modify the workflow as well? |
|
@flavio-fernandes thanks. this looks ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issue when making test:
Signed-off-by: Flavio Fernandes flaviof@redhat.com