-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: Make Rows() return a map of UUID to Models #247
Conversation
Pull Request Test Coverage Report for Build 1343352222
💛 - Coveralls |
/cc @trozet this fixes one of the panics you found |
@dave-tucker should the cache read have an RLock instead? |
oh I see there is an RLock inside Rows and Row, but not in the API call |
8334967
to
0556741
Compare
@trozet addressed this. rather than checking that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline comment, otherwise lgtm
@trozet removed the unncecessary calls to |
This makes Rows() return a map of UUID to Model. These models are copies of those in the cache at the time Rows() was called. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This makes Rows() return a map of UUID to Model.
These models are copies of those in the cache at the time Rows() was
called.