Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transactions block when using WithReconnect #261

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Nov 5, 2021

When creating a client using WithReconnect any requested Transact method
will block if the client is currently disconnected, and wait until it is
reconnected to execute the transaction (within a given context).

Signed-off-by: Tim Rozet trozet@redhat.com

@coveralls
Copy link

coveralls commented Nov 5, 2021

Pull Request Test Coverage Report for Build 1426474131

  • 7 of 20 (35.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 72.855%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/client.go 7 20 35.0%
Totals Coverage Status
Change from base Build 1426322545: -0.1%
Covered Lines: 4203
Relevant Lines: 5769

💛 - Coveralls

client/client.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
client/options.go Outdated Show resolved Hide resolved
When creating a client using WithReconnect any requested Transact method
will block if the client is currently disconnected, and wait until it is
reconnected to execute the transaction (within a given context).

Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet trozet force-pushed the optional_blocking_with_reconnect branch from cb4999a to d33a5ef Compare November 5, 2021 16:11
@trozet trozet changed the title Allow optional txn blocking with reconnect waiting for connection Nov 5, 2021
@trozet trozet changed the title waiting for connection Make transactions block when using WithReconnect Nov 5, 2021
Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit c6a8f91 into ovn-org:main Nov 5, 2021
@dave-tucker dave-tucker added the fix label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants