Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comments in ipMatchFromFile file via '#' token #2839

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

martinhsv
Copy link
Contributor

Lines that have '#' as the first character will be ignored in the same way that zero-length lines are ignored.
Lines that have '#' after legitimate content, e.g.:

127.0.0.1#A comment

... will have the characters beginning with the '#' ignored.

There is no new whitespace handling in this PR; whitespace remaining after the removal of comments is treated the same as before.

@martinhsv
Copy link
Contributor Author

Closes #2554

@martinhsv martinhsv merged commit 12e6e32 into owasp-modsecurity:v3/master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant