Fix: Setting of variable REQUEST_FILENAME #2862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airween
reviewed
Jan 18, 2023
airween
reviewed
Jan 19, 2023
|
Hi @PrajwalKrishna, thanks for your first time contribution! The mentioned variable has changed meantime, could you check that the behavior that you explained is still exists? |
|
Thanks @airween seems that the variable has been fixed. Would be closing this PR unless you think it is a good idea to make this test part of UTs. |
|
Hi @PrajwalKrishna, thanks for possibility, now I'm closing this PR, I think the behavior is what we expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
REQUEST_FILENAMEvariable includes the domain name from the URL while according to the documentation this is not the expected behaviour.The details of the existing bug can be found on an issue opened for the same - #2853